[PWGUD] Update FwdMuonsUPC#16307
Conversation
ariffero
commented
May 19, 2026
ariffero
commented
- Change V0A veto: veto only sel BC
- Remove histos and related configs
- Add checks on two-trakcs cand in FwdMuonsUPC
- Clean up of the task
|
O2 linter results: ❌ 1 errors, |
Please consider the following formatting changes to AliceO2Group#16307
Please consider the following formatting changes to AliceO2Group#16307
There was a problem hiding this comment.
Hi Andrea,
please, see this PR #15390 it seems you are reverting its changes. (usage of "" and <> in includes)
Also, please change the name of the file in a way that it does not start with a capital letter, so FwdMuonsUPC.cxx -> fwdMuonsUPC.cxx
Roman
Change "" to <> in include statements
Hi Roman, thanks for spotting that, I did not notice it before. Now it should be ok. |
Warnings on: PDG codes, header brackets and header included
Hi Andrea, it does not seem OK to me. You are still removing a lot of includes without apparent corresponding code changes. |
| HistogramRegistry mcRecoRegistry{"mcRecoRegistry", {}, OutputObjHandlingPolicy::AnalysisObject, true, true}; | ||
|
|
||
| // CONFIGURABLES | ||
| static constexpr double Pi = o2::constants::math::PI; |
There was a problem hiding this comment.
Please do not duplicate existing constants.
| static constexpr double Pi = o2::constants::math::PI; |
| Configurable<int> nBinsRapidity{"nBinsRapidity", 250, "N bins in rapidity histo"}; | ||
| Configurable<float> lowRapidity{"lowRapidity", -4.5, "lower limit in rapidity histo"}; | ||
| Configurable<float> highRapidity{"highRapidity", -2., "upper limit in rapidity histo"}; |
There was a problem hiding this comment.
There is ConfigurableAxis for this.
There was a problem hiding this comment.
tracks is not modified and should be passed by const&.
| if (candId < 0) { | ||
| continue; | ||
| } | ||
| if (std::abs(tr.pdgCode()) != pdg->GetParticle("mu-")->PdgCode()) { |
There was a problem hiding this comment.
Which PDG code do you want here?
There was a problem hiding this comment.
Members are not initialised.
| TLorentzVector p; | ||
| auto mMu = particleMass(kMuonPDG); | ||
| p.SetXYZM(fwdTrack.px(), fwdTrack.py(), fwdTrack.pz(), mMu); | ||
| ROOT::Math::PxPyPzMVector p{fwdTrack.px(), fwdTrack.py(), fwdTrack.pz(), o2::constants::physics::MassMuon}; |
There was a problem hiding this comment.
Why do you need a 4-vector?
| @@ -514,9 +384,9 @@ struct FwdMuonsUPC { | |||
| } | |||
There was a problem hiding this comment.
This seems overcomplicated. Don't you just want to pick randomly -1 or 1?
Please consider the following formatting changes to AliceO2Group#16307
Use pDCA and max amplitude of V0A as configurables instead of hard coded values.
For gen events that pass the reco, the calculation of the momentum of the pair had a typo.
Add check on number of tracks per candidates in the reco MC workflow. Add a return if gen tracks are not muons Remove misleading check on zdc time Remove commented out code and old comments
4 participants
